linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280: Move wcd specific pin conf to common file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 17:58:19 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Doug Anderson <dianders@...omium.org>
CC:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        <quic_rohkumar@...cinc.com>,
        "Srinivas Kandagatla" <srinivas.kandagatla@...aro.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Judy Hsiao <judyhsiao@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Move wcd specific pin conf to
 common file


On 7/7/2022 2:13 AM, Doug Anderson wrote:
Thanks for your time Doug!!!
> Hi,
>
> On Wed, Jul 6, 2022 at 3:17 AM Srinivasa Rao Mandadapu
> <quic_srivasam@...cinc.com> wrote:
>> +/* PINCTRL - BOARD-SPECIFIC */
> It's not really "board specific" since this is actually a file that's
> included by multiple boards.
Okay. Will update accordingly.
>
> Maybe just use the header "PINCTRL" for now. Everything here is just
> adding pull/drive strength/slew-rate info to existing pinctrl
> settings. If we ever have more than that and want to separate into
> different sections we can always adjust later.
>
>
>> +/*
>> + * Methodology for gpio-line-names:
>> + * - If a pin goes to CRD board and is named it gets that name.
>> + * - If a pin goes to CRD board and is not named, it gets no name.
>> + * - If a pin is totally internal to Qcard then it gets Qcard name.
>> + * - If a pin is not hooked up on Qcard, it gets no name.
>> + */
> This file doesn't include "gpio-line-names" so you don't need to
> include documentation about it.
Okay. Will remove it.
>
> -Doug