linux-kernel - Re: [PATCH v3 1/2] netfs: do not unlock and put the folio twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 07 Jul 2022 13:53:15 +0100
From:   David Howells <dhowells@...hat.com>
To:     xiubli@...hat.com
Cc:     dhowells@...hat.com, idryomov@...il.com, jlayton@...nel.org,
        marc.dionne@...istor.com, willy@...radead.org,
        keescook@...omium.org, kirill.shutemov@...ux.intel.com,
        william.kucharski@...cle.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ceph-devel@...r.kernel.org,
        linux-cachefs@...hat.com, vshankar@...hat.com
Subject: Re: [PATCH v3 1/2] netfs: do not unlock and put the folio twice

xiubli@...hat.com wrote:

> -error:
> +error_locked:
>  	folio_unlock(folio);
>  	folio_put(folio);
> +error_unlocked:

I would do:

	error:
		if (folio) {
			folio_unlock(folio);
			folio_put(folio);
		}

David