[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 7 Jul 2022 15:33:48 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Logananth Sundararaj <logananth13.hcl@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
SoC Team <soc@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Joel Stanley <joel@....id.au>,
Andrew Jeffery <andrew@...id.au>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
DTML <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
garnermic@...il.com, thangavel.k@....com, naveen.mosess@....com,
patrick@...cx.xyz, velumanit@....com
Subject: Re: [PATCH v3] The Yosemite V3.5 is a facebook multi-node server
platform that host four OCP server. The BMC in the Yosemite V3.5 platform
based on AST2600 SoC.
On Thu, Jul 7, 2022 at 3:20 PM Logananth Sundararaj
<logananth13.hcl@...il.com> wrote:
>
> This patch adds linux device tree entry related to
> Yosemite V3.5 specific devices connected to BMC SoC.
>
> Signed-off-by: Logananth Sundararaj <logananth_s@....com>
Something went wrong with the patch description, it looks like you dropped
the subject and sent the first paragraph as the subject instead.
> +/ {
> + model = "Facebook fby35";
> + compatible = "facebook,fby35", "aspeed,ast2600";
> +
> + aliases {
> + serial4 = &uart5;
> + };
Why not start at serial0 here?
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,57600n8 root=/dev/ram rw vmalloc=384M";
> + };
The bootargs should really come from the boot loader.
Why do you need the vmalloc=384M? That seems excessive.
> +
> + memory@...00000 {
> + device_type = "memory";
> + reg = <0x80000000 0x80000000>;
> + };
The memory location and size is usually also set by the boot loader
Arnd
Powered by blists - more mailing lists