linux-kernel - Re: [PATCH] efs: removed useless conditional checks in function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 15:34:28 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Andrey Strachuk <strochuk@...ras.ru>
Cc:     linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] efs: removed useless conditional checks in function

On Thu, Jul 07, 2022 at 05:26:52PM +0300, Andrey Strachuk wrote:
> However, it cannot be NULL because kernel crashes at
> line 293 otherwise.
> The patch removes useless comparisons.

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Not sure who's going to merge this patch.  I guess I can throw it into
the pagecache tree if nobody else wants it.

> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Strachuk <strochuk@...ras.ru>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

If you really want to be fancy, you can delve into linux-fullhistory and
come up with:

Fixes: 2b50c6738b500 ("Import 2.3.2")

although I bet that breaks a few scripts.