linux-kernel - Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 16:50:44 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Pin-Yen Lin <treapking@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc:     Hsin-Yi Wang <hsinyi@...omium.org>,
        Eizan Miyamoto <eizan@...omium.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3] arm64: dts: mt8173: Fix elm panel DT node



On 21/06/2022 11:18, Pin-Yen Lin wrote:
> Move the panel DT node under `aux-bus` node, so it won't use the buggy
> `ps8640_bridge_get_edid` to get the display modes. Also, change the
> compatible string from "lg,lp120up1" to "edp-panel", so the panel-edp
> driver gets the displays modes from the EDID instead of using the
> predefined display mode (`lg_lp129qe_mode`) in the driver, which is
> actually not working.
> 

Do we need a fixes tag here? I'm not quite sure if we fix an upstream bug here, 
to be honest.

Regards,
Matthias

> Signed-off-by: Pin-Yen Lin <treapking@...omium.org>
> ---
> 
> Changes in v3:
> - Include more details in the commit message.
> 
> Changes in v2:
> - Remove the Fixes tag because this change is not compatible with the
>    old kernel versions.
> 
>   arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
>   1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 9c75fbb31f98..1e0802a6f6d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,18 +90,6 @@ volume_up {
>   		};
>   	};
>   
> -	panel: panel {
> -		compatible = "lg,lp120up1";
> -		power-supply = <&panel_fixed_3v3>;
> -		backlight = <&backlight>;
> -
> -		port {
> -			panel_in: endpoint {
> -				remote-endpoint = <&ps8640_out>;
> -			};
> -		};
> -	};
> -
>   	panel_fixed_3v3: regulator1 {
>   		compatible = "regulator-fixed";
>   		regulator-name = "PANEL_3V3";
> @@ -282,6 +270,20 @@ ps8640_out: endpoint {
>   				};
>   			};
>   		};
> +
> +		aux-bus {
> +			panel {
> +				compatible = "edp-panel";
> +				power-supply = <&panel_fixed_3v3>;
> +				backlight = <&backlight>;
> +
> +				port {
> +					panel_in: endpoint {
> +						remote-endpoint = <&ps8640_out>;
> +					};
> +				};
> +			};
> +		};
>   	};
>   };
>