linux-kernel - [BUG] USB broken on rk3568 based R2Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 18:10:35 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     linux-phy@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Peter Geis <pgwipeout@...il.com>
Subject: [BUG] USB broken on rk3568 based R2Pro

Hi,

i noticed that upper usb-Port (otg) is broken on my Bananapi R2Pro with 5.19-rc1, works with 5.18.0

this port is a usb3 (xhci) port which includes an usb2-phy and should support otg, but i still want
to use it in host-only mode (USB-A socket).

already tried setting dr_mode in dts back to "host" as this was changed in rk356x.dtsi by this commit:

bc405bb3eeee 2022-04-25 arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x

i see no error in dmesg and usb-controllers seem to be initialized completely (visible in lsusb).

r2pro has ID-Pin not connected, so i tried also peters Patch without success :(

0901c01f8ac4 2022-06-21 phy: rockchip-inno-usb2: Sync initial otg state


so i tried bisect which seems to point to wrong commit (not related)...

$ git bisect log
git bisect start
# bad: [f2906aa863381afb0015a9eb7fefad885d4e5a56] Linux 5.19-rc1
git bisect bad f2906aa863381afb0015a9eb7fefad885d4e5a56
# good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18
git bisect good 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
# good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18
git bisect good 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
# good: [2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm
git bisect good 2518f226c60d8e04d18ba4295500a5b0b8ac7659
# good: [aef1ff15927421a55312b4b9b2881a89a344bd80] Merge tag 'jfs-5.19' of https://github.com/kleikamp/linux-shaggy
git bisect good aef1ff15927421a55312b4b9b2881a89a344bd80
# good: [09a018176ba246f00d6b6b526047d38dcd2955d3] Merge tag 'arm-late-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
git bisect good 09a018176ba246f00d6b6b526047d38dcd2955d3
# good: [54c2cc79194c961a213c1d375fe3aa4165664cc4] Merge tag 'usb-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
git bisect good 54c2cc79194c961a213c1d375fe3aa4165664cc4
# bad: [7036440eab3e2d47a775d4616909f8235488d714] ARM: omap1: enable multiplatform
git bisect bad 7036440eab3e2d47a775d4616909f8235488d714
# good: [46ee6bcac9838b7f74ff91f9cf38511c901ea9c5] Merge tag 'mhi-for-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi into char-work-next
git bisect good 46ee6bcac9838b7f74ff91f9cf38511c901ea9c5
# bad: [dc6a7effb48e7267c9f1314e3aa8cfe539bd6096] Merge tag 'lkdtm-next' of https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux into char-misc-next
git bisect bad dc6a7effb48e7267c9f1314e3aa8cfe539bd6096
# bad: [fa5602c62544ea5303ce870a9a3318fa7695ffc2] Merge tag 'soundwire-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire into char-misc-next
git bisect bad fa5602c62544ea5303ce870a9a3318fa7695ffc2
# bad: [f1b8d3358af77fc453d6b781f40ee7342a230672] phy: core: Add documentation of phy operation order
git bisect bad f1b8d3358af77fc453d6b781f40ee7342a230672
# bad: [2404387f521eda1d0eded58411bac2c719985d9c] phy/rockchip: Use of_device_get_match_data()
git bisect bad 2404387f521eda1d0eded58411bac2c719985d9c
# bad: [45d1f841d5a4afb415415f9f87c9d4ce15e19f42] dt-bindings: phy: uniphier-usb3hs: Fix incorrect clock-names and reset-names
git bisect bad 45d1f841d5a4afb415415f9f87c9d4ce15e19f42
# bad: [6f3652c952d8d8d22da1d535c470906da6e1afde] phy: qcom-qmp: Add SM6350 UFS PHY support
git bisect bad 6f3652c952d8d8d22da1d535c470906da6e1afde
# bad: [082ffee0505810bba7c4add343fa178861e26212] dt-bindings: phy: qcom,qmp: Add SM6350 UFS PHY bindings
git bisect bad 082ffee0505810bba7c4add343fa178861e26212
# bad: [e4d4371253029528c02bfb43a46c252e1c3d035f] phy: phy-can-transceiver: Add support for setting mux
git bisect bad e4d4371253029528c02bfb43a46c252e1c3d035f
# first bad commit: [e4d4371253029528c02bfb43a46c252e1c3d035f] phy: phy-can-transceiver: Add support for setting mux

have not replaced dtb while testing to exclude these changes

i looked through commits between good-bad-change and there are some for the rockchip-inno-usb2-phy where i guess the problem is located

git log --oneline 46ee6bcac9838b7f74ff91f9cf38511c901ea9c5..dc6a7effb48e7267c9f1314e3aa8cfe539bd6096

issue is maybe extcon (pointing to the usb2-phy) related as 5.18 uses extcon for this port.

Tried to find something in sysfs/debugfs, but without success.

maybe anyone has an idea? anything i can try/readout (sysfs/debugfs).

regards Frank