linux-kernel - Re: [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220708063307.GB195591@leoy-ThinkPad-X240s>
Date:   Fri, 8 Jul 2022 14:33:07 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Georgi Djakov <djakov@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and
 clock for bucket values

On Thu, Jul 07, 2022 at 05:33:58PM +0300, Georgi Djakov wrote:

[...]

> > @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> >   	provider = src->provider;
> >   	qp = to_qcom_provider(provider);
> > -	list_for_each_entry(n, &provider->nodes, node_list)
> > -		provider->aggregate(n, 0, n->avg_bw, n->peak_bw,
> > -				    &agg_avg, &agg_peak);
> > +	qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg,
> > +			       &max_agg_peak);
> > -	sum_bw = icc_units_to_bps(agg_avg);
> > -	max_peak_bw = icc_units_to_bps(agg_peak);
> > +	sum_bw = icc_units_to_bps(max_agg_avg);
> > +	max_peak_bw = icc_units_to_bps(max_agg_peak);
> >   	ret = __qcom_icc_set(src, src_qn, sum_bw);
> >   	if (ret)
> > @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> >   			return ret;
> >   	}
> > -	rate = max(sum_bw, max_peak_bw);
> 
> Looks like max_peak_bw is unused now?

Yes, will drop it in next spin.

Thanks for review.

Leo