linux-kernel - Re: [PATCH v2 2/2] clk: renesas: rcar-gen4: Fix initconst confusion for cpg_pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Jul 2022 09:27:30 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        Martin Liska <mliska@...e.cz>, Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v2 2/2] clk: renesas: rcar-gen4: Fix initconst confusion
 for cpg_pll_config

Hi Jiri,

On Fri, Jul 8, 2022 at 9:13 AM Jiri Slaby <jslaby@...e.cz> wrote:
> From: Andi Kleen <ak@...ux.intel.com>
>
> A variable pointing to const isn't const itself. It'd have to contain
> "const" keyword after "*" too. Therefore, cpg_pll_config cannot be put
> to "rodata".  Hence use __initdata instead of __initconst to fix this.
>
> [js] more explanatory commit message.
>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: linux-renesas-soc@...r.kernel.org
> Cc: linux-clk@...r.kernel.org
> Cc: Martin Liska <mliska@...e.cz>
> Acked-by: Stephen Boyd <sboyd@...nel.org>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Already queued as commit 0e704f6c42dc64f0 ("clk: renesas: rcar-gen4:
Fix initconst confusion for cpg_pll_config") in renesas-clk-for-v5.20,
and next-20220706 and later.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds