linux-kernel - Re: [PATCH v2] sunxi: dts: Fix SPI NOR campatible on Orange Pi Zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c575068-abd7-c69a-e59c-3140f8cb7813@sholland.org>
Date:   Fri, 8 Jul 2022 02:36:26 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Michal Suchanek <msuchanek@...e.de>,
        Jernej Skrabec <jernej.skrabec@...il.com>
Cc:     linux-sunxi@...ts.linux.dev, Icenowy Zheng <icenowy@...c.xyz>,
        Andre Przywara <andre.przywara@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sunxi: dts: Fix SPI NOR campatible on Orange Pi Zero

Hi Michal,

The subject prefix should start with "ARM: dts:" (e.g. "ARM: dts: sunxi:").
Generally it is a good idea to look at the log of the file and follow the
pattern you see there.

On 7/7/22 12:07 PM, Michal Suchanek wrote:
> Without "jedec,spi-nor" compatible the flash memory cannot be probed by
> u-boot. The macronix part is what is shipped on the boards that come
> with a flash chip.
> 

Fixes: 45857ae95478 ("ARM: dts: orange-pi-zero: add node for SPI NOR")

Regards,
Samuel

> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
>  arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index f19ed981da9d..3706216ffb40 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -169,7 +169,7 @@ &spi0 {
>  	flash@0 {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> -		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> +		compatible = "mxicy,mx25l1606e", "jedec,spi-nor";
>  		reg = <0>;
>  		spi-max-frequency = <40000000>;
>  	};
>