linux-kernel - Re: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee0d9788-b742-21bb-9cc5-7b729897408b@collabora.com>
Date:   Fri, 8 Jul 2022 10:01:20 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Zhongjun Tan <hbut_tan@....com>, lgirdwood@...il.com,
        broonie@...nel.org, perex@...ex.c, tiwai@...e.com,
        matthias.bgg@...il.com, jiaxin.yu@...iatek.com,
        tanzhongjun@...lpad.com, colin.king@...el.com
Cc:     alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect

Il 08/07/22 04:46, Zhongjun Tan ha scritto:
> From: Zhongjun Tan <tanzhongjun@...lpad.com>
> 
> Remove condition with no effect
> 
> Signed-off-by: Zhongjun Tan <tanzhongjun@...lpad.com>
> ---
>   sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> index db71b032770d..6be6d4f3b585 100644
> --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
> @@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct snd_soc_dapm_widget *w,
>   	case SND_SOC_DAPM_PRE_PMU:
>   		if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2_CLK_P2)
>   			regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x39);
> -		else if (afe_priv->mtkaif_protocol == MTKAIF_PROTOCOL_2)
> -			regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);

I think that this needs some clarification from MediaTek: was 0x31 a typo here?

Regards,
Angelo

>   		else
>   			regmap_write(afe->regmap, AFE_AUD_PAD_TOP, 0x31);
>   		break;