linux-kernel - Re: [PATCH] net: l2tp: fix clang -Wformat warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165724381263.6017.3389511636331557428.git-patchwork-notify@kernel.org>
Date:   Fri, 08 Jul 2022 01:30:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Justin Stitt <justinstitt@...gle.com>
Cc:     jchapman@...alix.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org,
        ndesaulniers@...gle.com, trix@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] net: l2tp: fix clang -Wformat warning

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed,  6 Jul 2022 16:08:33 -0700 you wrote:
> When building with clang we encounter this warning:
> | net/l2tp/l2tp_ppp.c:1557:6: error: format specifies type 'unsigned
> | short' but the argument has type 'u32' (aka 'unsigned int')
> | [-Werror,-Wformat] session->nr, session->ns,
> 
> Both session->nr and session->ns are of type u32. The format specifier
> previously used is `%hu` which would truncate our unsigned integer from
> 32 to 16 bits. This doesn't seem like intended behavior, if it is then
> perhaps we need to consider suppressing the warning with pragma clauses.
> 
> [...]

Here is the summary with links:
  - net: l2tp: fix clang -Wformat warning
    https://git.kernel.org/netdev/net-next/c/a2b6111b55f3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html