linux-kernel - Re: [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media blk ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48cb64bd-fc0c-a385-f1b0-765ca17cfbbb@oss.nxp.com>
Date:   Fri, 8 Jul 2022 08:06:54 +0800
From:   Peng Fan <peng.fan@....nxp.com>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     djakov@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        festevam@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, abelvesa@...nel.org,
        abailon@...libre.com, l.stach@...gutronix.de,
        laurent.pinchart@...asonboard.com, marex@...x.de,
        paul.elder@...asonboard.com, Markus.Niebel@...tq-group.com,
        aford173@...il.com, devicetree@...r.kernel.org,
        Peng Fan <peng.fan@....com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 6/7] arm64: dts: imx8mp: add interconnects for media
 blk ctrl



On 7/7/2022 7:38 PM, Marco Felsch wrote:
> Hi,
> 
> thanks for your patch and the work on this.
> 
> On 22-07-03, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@....com>
>>
>> Add interconnect property for media blk ctrl
>>
>> Signed-off-by: Peng Fan <peng.fan@....com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> index 13a2ee77d3c6..08bd57742294 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> 
> Can you please add:
> 
> #include <dt-bindings/interconnect/fsl,imx8mp.h>
> 
> else this won't compile.

oh, ICC maintainer asked me to drop this header when adding
NoC node, and I need to add this header when there
is user. Here it is, I will add it and post a V4.

Thanks,
Peng.

> 
> Regards,
>    Marco
> 
>> @@ -1066,6 +1066,18 @@ media_blk_ctrl: blk-ctrl@...c0000 {
>>   						     "lcdif1", "isi", "mipi-csi2",
>>   						     "lcdif2", "isp", "dwe",
>>   						     "mipi-dsi2";
>> +				interconnects =
>> +					<&noc IMX8MP_ICM_LCDIF_RD &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_LCDIF_WR &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_ISI0 &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_ISI1 &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_ISI2 &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_ISP0 &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_ISP1 &noc IMX8MP_ICN_MEDIA>,
>> +					<&noc IMX8MP_ICM_DWE &noc IMX8MP_ICN_MEDIA>;
>> +				interconnect-names = "lcdif-rd", "lcdif-wr", "isi0",
>> +						     "isi1", "isi2", "isp0", "isp1",
>> +						     "dwe";
>>   				clocks = <&clk IMX8MP_CLK_MEDIA_APB_ROOT>,
>>   					 <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
>>   					 <&clk IMX8MP_CLK_MEDIA_CAM1_PIX_ROOT>,
>> -- 
>> 2.25.1
>>
>>
>>