linux-kernel - Re: [PATCH] vdpa_sim: use max_iotlb_entries as a limit in vhost_iotlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Jul 2022 13:23:07 +0200
From:   Eugenio Perez Martin <eperezma@...hat.com>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     virtualization <virtualization@...ts.linux-foundation.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Gautam Dawar <gautam.dawar@...inx.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH] vdpa_sim: use max_iotlb_entries as a limit in vhost_iotlb_init

On Tue, Jun 21, 2022 at 5:16 PM Stefano Garzarella <sgarzare@...hat.com> wrote:
>
> Commit bda324fd037a ("vdpasim: control virtqueue support") changed
> the allocation of iotlbs calling vhost_iotlb_init() for each address
> space, instead of vhost_iotlb_alloc().
>
> With this change we forgot to use the limit we had introduced with
> the `max_iotlb_entries` module parameter.
>
> Fixes: bda324fd037a ("vdpasim: control virtqueue support")
> Cc: gautam.dawar@...inx.com
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>

Acked-by: Eugenio Pérez <eperezma@...hat.com>

> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index 0f2865899647..3e81532c01cb 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -33,7 +33,7 @@ MODULE_PARM_DESC(batch_mapping, "Batched mapping 1 -Enable; 0 - Disable");
>  static int max_iotlb_entries = 2048;
>  module_param(max_iotlb_entries, int, 0444);
>  MODULE_PARM_DESC(max_iotlb_entries,
> -                "Maximum number of iotlb entries. 0 means unlimited. (default: 2048)");
> +                "Maximum number of iotlb entries for each address space. 0 means unlimited. (default: 2048)");
>
>  #define VDPASIM_QUEUE_ALIGN PAGE_SIZE
>  #define VDPASIM_QUEUE_MAX 256
> @@ -291,7 +291,7 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
>                 goto err_iommu;
>
>         for (i = 0; i < vdpasim->dev_attr.nas; i++)
> -               vhost_iotlb_init(&vdpasim->iommu[i], 0, 0);
> +               vhost_iotlb_init(&vdpasim->iommu[i], max_iotlb_entries, 0);
>
>         vdpasim->buffer = kvmalloc(dev_attr->buffer_size, GFP_KERNEL);
>         if (!vdpasim->buffer)
> --
> 2.36.1
>