linux-kernel - Aw: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-e64eb9b8-7b25-4893-a1a2-ecbf9da3ef71-1657280834206@3c-app-gmx-bs34>
Date:   Fri, 8 Jul 2022 13:47:14 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Geis <pgwipeout@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-phy@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Aw: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode

Hi Samuel

thx for the fix...with this it works again

Tested-by: Frank Wunderlich <frank-w@...lic-files.de>

regards Frank


> Gesendet: Freitag, 08. Juli 2022 um 08:14 Uhr
> Von: "Samuel Holland" <samuel@...lland.org>
> An: "Frank Wunderlich" <frank-w@...lic-files.de>, "Vinod Koul" <vkoul@...nel.org>
> Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Peter Geis" <pgwipeout@...il.com>, "Samuel Holland" <samuel@...lland.org>, "Heiko Stuebner" <heiko@...ech.de>, "Kishon Vijay Abraham I" <kishon@...com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org, linux-rockchip@...ts.infradead.org
> Betreff: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode
>
> When the OTG port is fixed to host mode, the driver does not request its
> IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
> should ignore the OTG port IRQs when handling the shared interrupt.
>
> Otherwise, it would update the extcon based on an ID pin which may be in
> an undefined state, or try to queue a uninitialized work item.
>
> Fixes: 6a98df08ccd5 ("phy: rockchip-inno-usb2: Fix muxed interrupt support")
> Reported-by: Frank Wunderlich <frank-w@...lic-files.de>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
>
>  drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> index 6711659f727c..26b841c49ec6 100644
> --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> @@ -978,7 +978,9 @@ static irqreturn_t rockchip_usb2phy_irq(int irq, void *data)
>
>  		switch (rport->port_id) {
>  		case USB2PHY_PORT_OTG:
> -			ret |= rockchip_usb2phy_otg_mux_irq(irq, rport);
> +			if (rport->mode != USB_DR_MODE_HOST &&
> +			    rport->mode != USB_DR_MODE_UNKNOWN)
> +				ret |= rockchip_usb2phy_otg_mux_irq(irq, rport);
>  			break;
>  		case USB2PHY_PORT_HOST:
>  			ret |= rockchip_usb2phy_linestate_irq(irq, rport);
> --
> 2.35.1
>
>