linux-kernel - Re: [PATCH v6 1/2] highmem: Make __kunmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a665668a-4a10-d39e-d879-7f43aafad333@gmx.de>
Date:   Fri, 8 Jul 2022 14:47:00 +0200
From:   Helge Deller <deller@....de>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     David Sterba <dsterba@...e.com>, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        Nick Terrell <terrelln@...com>, linux-btrfs@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Ira Weiny <ira.weiny@...el.com>,
        Matthew Wilcox <willy@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "James E. J. Bottomley" <James.Bottomley@...senPartnership.com>,
        John David Anglin <dave.anglin@...l.net>,
        linux-parisc@...r.kernel.org, David Sterba <dsterba@...e.cz>
Subject: Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take
 "const void *"

On 7/6/22 21:07, Andrew Morton wrote:
> On Wed,  6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" <fmdefrancesco@...il.com> wrote:
>
>> __kunmap_ {local,atomic}() currently take pointers to void. However, this
>> is semantically incorrect, since these functions do not change the memory
>> their arguments point to.
>>
>> Therefore, make this semantics explicit by modifying the
>> __kunmap_{local,atomic}() prototypes to take pointers to const void.
>>
>> As a side effect, compilers will likely produce more efficient code.
>>
>
> Acked-by: Andrew Morton <akpm@...ux-foundation.org>

Acked-by: Helge Deller <deller@....de>  # parisc

> Please include this in the btrfs tree if/when [2/2] is added.

Yes, agreed. Please take both through btrfs.

Helge