linux-kernel - Re: [PATCH 0/3] DL capacity-aware fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ysgy2XkdceBaHz04@localhost.localdomain>
Date:   Fri, 8 Jul 2022 15:36:25 +0200
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        Mel Gorman <mgorman@...e.de>, Ben Segall <bsegall@...gle.com>,
        Luca Abeni <luca.abeni@...tannapisa.it>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] DL capacity-aware fixes

Hi,

On 29/06/22 14:20, Dietmar Eggemann wrote:
> While testing cpusets on asymmetric CPU capacity systems I realized that
> the admission control, which kicks in when the cpumask of a cpuset is
> about to be changed, is not capacity-aware. [PATCH 2/3] addresses this
> issue.
> 
> Overview:
> 
> [PATCH 1/3] - Not part of the DL related changes but here for
>               convenience : Inline helper function around
>               static_branch_unlikely(&sched_asym_cpucapacity)
> 
> [PATCH 2/3] - Make dl_cpuset_cpumask_can_shrink() capacity-aware.
> 
> [PATCH 3/3] - Save a multiplication in dl_task_fits_capacity() by using
> 	      already maintained dl_density.

I had a look as well and, other than Vincent's comment on 3/3, the set
looked good to me. Looking forward for v2. :)

Thanks,
Juri