linux-kernel - Re: [RFC 2/4] arch-topology: add a default implementation of store_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220708135932.7srpzia53jbpmitg@bogus>
Date:   Fri, 8 Jul 2022 14:59:32 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Conor.Dooley@...rochip.com
Cc:     gregkh@...uxfoundation.org, geert@...ux-m68k.org,
        paul.walmsley@...ive.com, palmer@...belt.com, palmer@...osinc.com,
        aou@...s.berkeley.edu, catalin.marinas@....com, will@...nel.org,
        rafael@...nel.org, Daire.McNamara@...rochip.com,
        niklas.cassel@....com, damien.lemoal@...nsource.wdc.com,
        zong.li@...ive.com, kernel@...il.dk, hahnjo@...njo.de,
        guoren@...nel.org, anup@...infault.org, atishp@...shpatra.org,
        changbin.du@...el.com, heiko@...ech.de, philipp.tomsich@...ll.eu,
        robh@...nel.org, maz@...nel.org, viresh.kumar@...aro.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Brice.Goglin@...ia.fr
Subject: Re: [RFC 2/4] arch-topology: add a default implementation of
 store_cpu_topology()

On Fri, Jul 08, 2022 at 11:57:05AM +0000, Conor.Dooley@...rochip.com wrote:
> 
> I did a little bit of poking in the git history.
> The last code touching the arm implementation was:
> 3102bc0e6ac7 ("arm64: topology: Stop using MPIDR for topology information")
> on Fri Oct 2 12:01:41 2020 +0100
> 
> The introduction of arch-topology stuff to RISC-V was:
> 03f11f03dbfe ("RISC-V: Parse cpu topology during boot.")
> on Thu Jun 27 12:53:00 2019 -0700
> 
> Backporting as far as v5.10 should be no real effort and I don't think
> to v5.4 that should be meaninfully harder. If 3102bc0e6ac7 hasn't been
> backported already, maybe it should be since it appears to have been
> fixing a problem too.
>

Thanks for doing the research and sorry for the noise earlier.

> Based on that, I think doing this the straightforward way in the first
> place is a better idea.
> 
> I'll respin the series as:
> patch 1: Move arm64 to the generic implementation

I don't think the mpidr check we have there is of much use IMO. You can
drop that and see if arm64 maintainers and/or others agree. As you have
already figured, since 3102bc0e6ac7 we are not using MPIDR and the one
check we have is optional IMO. So you can either drop it or keep it as
in your RFC and then post updates.

-- 
Regards,
Sudeep