linux-kernel - Re: [PATCH] drm/amd/display: Remove condition with no effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33277b4f-5147-2857-5d23-fe68674ab3b0@amd.com>
Date:   Fri, 8 Jul 2022 11:02:17 -0400
From:   Harry Wentland <harry.wentland@....com>
To:     Zhongjun Tan <hbut_tan@....com>, sunpeng.li@....com,
        Rodrigo.Siqueira@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
        daniel@...ll.ch, chandan.vurdigerenataraj@....com,
        tanzhongjun@...lpad.com, aurabindo.pillai@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: Remove condition with no effect

On 2022-07-07 23:10, Zhongjun Tan wrote:
> From: Zhongjun Tan <tanzhongjun@...lpad.com>
> 
> Remove condition with no effect

Please explain why you think this has no effect.

Harry

> 
> Signed-off-by: Zhongjun Tan <tanzhongjun@...lpad.com>
> ---
>  .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c   | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index 07f3a85f8edf..ec3ea94d3802 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4670,10 +4670,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>  	} else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
>  		*MinPrefetchMode = 0;
>  		*MaxPrefetchMode = 0;
> -	} else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> -			dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> -		*MinPrefetchMode = 0;
> -		*MaxPrefetchMode = 3;
>  	} else {
>  		*MinPrefetchMode = 0;
>  		*MaxPrefetchMode = 3;