linux-kernel - Re: [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c166a4a-d0a8-b225-fee9-14ad2898ebc6@microchip.com>
Date:   Fri, 8 Jul 2022 15:15:47 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <michael@...le.cc>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <Nicolas.Ferre@...rochip.com>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: kswitch-d10: use open drain mode for coma-mode
 pins

On 04.07.2022 18:08, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The driver use the coma-mode pins as open-drain. Flag them in the device
> tree accordingly. This avoids the following error:
> [   14.114180] gpio-2007 (coma-mode): enforced open drain please flag it properly in DT/ACPI DSDT/board file
> 
> Fixes: 46a9556d977e ("ARM: dts: kswitch-d10: enable networking")
> Signed-off-by: Michael Walle <michael@...le.cc>

Applied to at91-fixes, thanks!

> ---
>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 949d49944a37..5a6c5f7c371a 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -87,22 +87,22 @@ &mdio0 {
> 
>         phy4: ethernet-phy@5 {
>                 reg = <5>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy5: ethernet-phy@6 {
>                 reg = <6>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy6: ethernet-phy@7 {
>                 reg = <7>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
> 
>         phy7: ethernet-phy@8 {
>                 reg = <8>;
> -               coma-mode-gpios = <&gpio 37 GPIO_ACTIVE_HIGH>;
> +               coma-mode-gpios = <&gpio 37 GPIO_OPEN_DRAIN>;
>         };
>  };
> 
> --
> 2.30.2
>