linux-kernel - Re: [RESEND PATCH] kernfs: Avoid re-adding kernfs_node into kernfs_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdY=UoBnL=vGkq2xPX6OBD2aDgB+t85z=zKpS1ovin4=w@mail.gmail.com>
Date:   Fri, 8 Jul 2022 17:58:51 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Imran Khan <imran.f.khan@...cle.com>
Cc:     Tejun Heo <tj@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Rob Herring <robh@...nel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Guillaume Tucker <guillaume.tucker@...labora.com>,
        Petr Mladek <pmladek@...e.com>
Subject: Re: [RESEND PATCH] kernfs: Avoid re-adding kernfs_node into kernfs_notify_list.

On Fri, Jul 1, 2022 at 5:49 PM Imran Khan <imran.f.khan@...cle.com> wrote:

...

> +       if (kn->attr.notify_next.next != NULL) {

Isn't there a helper to get next pointer from an llist pointer?

> +               kernfs_get(kn);
> +               llist_add(&kn->attr.notify_next, &kernfs_notify_list);
> +               schedule_work(&kernfs_notify_work);
> +       }

-- 
With Best Regards,
Andy Shevchenko