linux-kernel - [PATCH] i3c: master; add error print for invalid node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220708164948.268930-1-ben.dooks@sifive.com>
Date:   Fri,  8 Jul 2022 17:49:48 +0100
From:   Ben Dooks <ben.dooks@...ive.com>
To:     linux-i3c@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, alexandre.belloni@...tlin.com,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>,
        Sudip Mukherjee <sudip.mukherjee@...ive.com>,
        Ben Dooks <ben.dooks@...ive.com>
Subject: [PATCH] i3c: master; add error print for invalid node

Show an error if the OF code in the i3c master setup
failed to read the register, so that if an incorrect
node is supplied there is an error print to make it
clear what the problem is

Signed-off-by: Ben Dooks <ben.dooks@...ive.com>
---
 drivers/i3c/master.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7850287dfe7a..271d687d0d07 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2082,8 +2082,10 @@ static int of_i3c_master_add_dev(struct i3c_master_controller *master,
 		return -EINVAL;
 
 	ret = of_property_read_u32_array(node, "reg", reg, ARRAY_SIZE(reg));
-	if (ret)
+	if (ret) {
+		dev_err(&master->dev, "i3c: invalid reg for %pOF\n", node);
 		return ret;
+	}
 
 	/*
 	 * The manufacturer ID can't be 0. If reg[1] == 0 that means we're
-- 
2.35.1