linux-kernel - Re: [PATCH] docs/kselftest: Fix build commands in guidelines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58aad5c5-339f-85b9-8f48-0ffbd133b0cb@linuxfoundation.org>
Date:   Fri, 8 Jul 2022 10:51:40 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Shuah Khan <shuah@...nel.org>, Jonathan Corbet <corbet@....net>
Cc:     kernel@...labora.com, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] docs/kselftest: Fix build commands in guidelines

On 7/4/22 2:34 AM, Muhammad Usama Anjum wrote:
> Build commands start with "make". It is missing. Add "make" to the start
> of the build command.
> 
> Fixes: 820636106342 ("docs/kselftest: add more guidelines for adding new tests")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
>   Documentation/dev-tools/kselftest.rst | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index ee6467ca8293..9dd94c334f05 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -255,9 +255,9 @@ Contributing new tests (details)
>   
>    * All changes should pass::
>   
> -    kselftest-{all,install,clean,gen_tar}
> -    kselftest-{all,install,clean,gen_tar} O=abo_path
> -    kselftest-{all,install,clean,gen_tar} O=rel_path
> +    make kselftest-{all,install,clean,gen_tar}
> +    make kselftest-{all,install,clean,gen_tar} O=abs_path
> +    make kselftest-{all,install,clean,gen_tar} O=rel_path
>       make -C tools/testing/selftests {all,install,clean,gen_tar}
>       make -C tools/testing/selftests {all,install,clean,gen_tar} O=abs_path
>       make -C tools/testing/selftests {all,install,clean,gen_tar} O=rel_path
> 

Looks like it depends on a patch already in doc tree?

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah