linux-kernel - [PATCH] devres: show which resource was invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220708170554.270405-1-ben.dooks@sifive.com>
Date:   Fri,  8 Jul 2022 18:05:54 +0100
From:   Ben Dooks <ben.dooks@...ive.com>
To:     linux-kernel@...r.kernel.org
Cc:     Sudip Mukherjee <sudip.mukherjee@...ive.com>,
        Jude Onyenegecha <jude.onyenegecha@...ive.com>,
        Ben Dooks <ben.dooks@...ive.com>
Subject: [PATCH] devres: show which resource was invalid

If we do find a resouce that's not valid, print it to aid
identifying the issue.

Signed-off-by: Ben Dooks <ben.dooks@...ive.com>
---
 lib/devres.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/devres.c b/lib/devres.c
index 14664bbb4875..df5ed06908f0 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -143,7 +143,7 @@ __devm_ioremap_resource(struct device *dev, const struct resource *res,
 	BUG_ON(!dev);
 
 	if (!res || resource_type(res) != IORESOURCE_MEM) {
-		dev_err(dev, "invalid resource\n");
+		dev_err(dev, "invalid resource (%pR)\n", res);
 		return IOMEM_ERR_PTR(-EINVAL);
 	}
 
-- 
2.35.1