linux-kernel - Re: [PATCH] bus: mhi: ep: Check dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220709060749.GB5063@thinkpad>
Date:   Sat, 9 Jul 2022 11:37:49 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Bo Liu <liubo03@...pur.com>
Cc:     mani@...nel.org, quic_hemantk@...cinc.com, mhi@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: mhi: ep: Check dev_set_name() return value

On Thu, Jul 07, 2022 at 09:59:48PM -0400, Bo Liu wrote:
> It's possible that dev_set_name() returns -ENOMEM, catch and handle this.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/ep/main.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 40109a79017a..1dc8a3557a46 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1242,9 +1242,13 @@ static int mhi_ep_create_device(struct mhi_ep_cntrl *mhi_cntrl, u32 ch_id)
>  
>  	/* Channel name is same for both UL and DL */
>  	mhi_dev->name = mhi_chan->name;
> -	dev_set_name(&mhi_dev->dev, "%s_%s",
> +	ret = dev_set_name(&mhi_dev->dev, "%s_%s",
>  		     dev_name(&mhi_cntrl->mhi_dev->dev),
>  		     mhi_dev->name);
> +	if (ret) {
> +		put_device(&mhi_dev->dev);
> +		return ret;
> +	}
>  
>  	ret = device_add(&mhi_dev->dev);
>  	if (ret)
> @@ -1408,7 +1412,10 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
>  		goto err_free_irq;
>  	}
>  
> -	dev_set_name(&mhi_dev->dev, "mhi_ep%u", mhi_cntrl->index);
> +	ret = dev_set_name(&mhi_dev->dev, "mhi_ep%u", mhi_cntrl->index);
> +	if (ret)
> +		goto err_put_dev;
> +
>  	mhi_dev->name = dev_name(&mhi_dev->dev);
>  	mhi_cntrl->mhi_dev = mhi_dev;
>  
> -- 
> 2.27.0
> 

-- 
மணிவண்ணன் சதாசிவம்