linux-kernel - [ammarfaizi2-block:stable/linux-stable-rc/queue/5.15 156/161] drivers/irqchip/irq-gic-v3.c:666:9: error: expected ';' before 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202207091422.mERbR7Ce-lkp@intel.com>
Date:   Sat, 9 Jul 2022 14:40:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mark Rutland <mark.rutland@....com>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Sasha Levin <sashal@...nel.org>,
        Marc Zyngier <maz@...nel.org>
Subject: [ammarfaizi2-block:stable/linux-stable-rc/queue/5.15 156/161]
 drivers/irqchip/irq-gic-v3.c:666:9: error: expected ';' before 'err'

tree:   https://github.com/ammarfaizi2/linux-block stable/linux-stable-rc/queue/5.15
head:   ab88938c957f2e2edc60e19ab6df7830fc1c6914
commit: 66b9343ecbdd4d09a72bc854094a03ca858c2077 [156/161] irqchip/gic-v3: Ensure pseudo-NMIs have an ISB between ack and handling
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220709/202207091422.mERbR7Ce-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/66b9343ecbdd4d09a72bc854094a03ca858c2077
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block stable/linux-stable-rc/queue/5.15
        git checkout 66b9343ecbdd4d09a72bc854094a03ca858c2077
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-gic-v3.c: In function 'gic_handle_nmi':
>> drivers/irqchip/irq-gic-v3.c:666:9: error: expected ';' before 'err'
     666 |         err = handle_domain_nmi(gic_data.domain, irqnr, regs);
         |         ^~~


vim +666 drivers/irqchip/irq-gic-v3.c

f32c926651dcd1 Julien Thierry 2019-01-31  646  
f32c926651dcd1 Julien Thierry 2019-01-31  647  static inline void gic_handle_nmi(u32 irqnr, struct pt_regs *regs)
f32c926651dcd1 Julien Thierry 2019-01-31  648  {
17ce302f3117e9 Julien Thierry 2019-06-11  649  	bool irqs_enabled = interrupts_enabled(regs);
f32c926651dcd1 Julien Thierry 2019-01-31  650  	int err;
f32c926651dcd1 Julien Thierry 2019-01-31  651  
17ce302f3117e9 Julien Thierry 2019-06-11  652  	if (irqs_enabled)
17ce302f3117e9 Julien Thierry 2019-06-11  653  		nmi_enter();
17ce302f3117e9 Julien Thierry 2019-06-11  654  
f32c926651dcd1 Julien Thierry 2019-01-31  655  	if (static_branch_likely(&supports_deactivate_key))
f32c926651dcd1 Julien Thierry 2019-01-31  656  		gic_write_eoir(irqnr);
66b9343ecbdd4d Mark Rutland   2022-05-13  657  	else
66b9343ecbdd4d Mark Rutland   2022-05-13  658  		isb()
66b9343ecbdd4d Mark Rutland   2022-05-13  659  
f32c926651dcd1 Julien Thierry 2019-01-31  660  	/*
f32c926651dcd1 Julien Thierry 2019-01-31  661  	 * Leave the PSR.I bit set to prevent other NMIs to be
f32c926651dcd1 Julien Thierry 2019-01-31  662  	 * received while handling this one.
f32c926651dcd1 Julien Thierry 2019-01-31  663  	 * PSR.I will be restored when we ERET to the
f32c926651dcd1 Julien Thierry 2019-01-31  664  	 * interrupted context.
f32c926651dcd1 Julien Thierry 2019-01-31  665  	 */
f32c926651dcd1 Julien Thierry 2019-01-31 @666  	err = handle_domain_nmi(gic_data.domain, irqnr, regs);
f32c926651dcd1 Julien Thierry 2019-01-31  667  	if (err)
f32c926651dcd1 Julien Thierry 2019-01-31  668  		gic_deactivate_unhandled(irqnr);
17ce302f3117e9 Julien Thierry 2019-06-11  669  
17ce302f3117e9 Julien Thierry 2019-06-11  670  	if (irqs_enabled)
17ce302f3117e9 Julien Thierry 2019-06-11  671  		nmi_exit();
f32c926651dcd1 Julien Thierry 2019-01-31  672  }
f32c926651dcd1 Julien Thierry 2019-01-31  673  

:::::: The code at line 666 was first introduced by commit
:::::: f32c926651dcd1683f4d896ee52609000a62a3dc irqchip/gic-v3: Handle pseudo-NMIs

:::::: TO: Julien Thierry <julien.thierry@....com>
:::::: CC: Catalin Marinas <catalin.marinas@....com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp