linux-kernel - Re: [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 9 Jul 2022 09:02:46 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        Forest Bond <forest@...ttletooquiet.net>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6655: Use loop in
 vt6655_mac_write_bssid_addr

On Fri, Jul 08, 2022 at 09:07:43PM -0700, Joe Perches wrote:
> On Fri, 2022-07-08 at 14:29 +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jul 06, 2022 at 09:19:01PM +0200, Philipp Hortmann wrote:
> > > Use loop in vt6655_mac_write_bssid_addr to avoid multiple
> > > similar statements.
> []
> > > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> []
> > > @@ -192,12 +192,8 @@ device_set_options(struct vnt_private *priv)
> > >  static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr)
> []
> > > +	for (int i = 0; i < 6; i++)
> > 
> > Taking advantage of the new compiler level I see, nice :)
> 
> Not sure this is altogether a great idea as it may
> make backporting a bit difficult, but it's already
> in the kernel in a few places.

That's for the stable kernels to worry about, don't let that stop new
development from happening for that reason please.

thanks,

greg k-h