linux-kernel - Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Jul 2022 13:44:16 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     PaddyKP_Yao <ispaddy@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Corentin Chary <corentin.chary@...il.com>,
        Luke Jones <luke@...nes.dev>, PaddyKP_Yao@...s.com,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>
Subject: Re: [PATCH 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

You have sent two patches with the same version, your submission
confuses everybody, which one are we supposed to consider?

On Fri, Jul 8, 2022 at 11:08 AM PaddyKP_Yao <ispaddy@...il.com> wrote:
>
> In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
> LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
> mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
> it. The binding of mic-mute LED controls will be swithched with LED

switched

> trigger.

...

Not reviewing code because of the above.

Hint: `git format-patch -vX ...`, where X is a version number will
help. And when cooking a new version don't forget to add a changelog
between versions.

-- 
With Best Regards,
Andy Shevchenko