lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202207100404.Kq7TRZqu-lkp@intel.com>
Date:   Sun, 10 Jul 2022 04:37:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: include/trace/events/rcu.h:724:17: warning: 'strncpy' specified
 bound 8 equals destination size

Hi Heiko,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f
commit: 334ef6ed06fa1a54e35296b77b693bcf6d63ee9e init/Kconfig: make COMPILE_TEST depend on !S390
date:   1 year, 8 months ago
config: s390-randconfig-r023-20220710 (https://download.01.org/0day-ci/archive/20220710/202207100404.Kq7TRZqu-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=334ef6ed06fa1a54e35296b77b693bcf6d63ee9e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 334ef6ed06fa1a54e35296b77b693bcf6d63ee9e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash fs/fscache/ kernel/rcu/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:103,
                    from include/trace/events/rcu.h:785,
                    from kernel/rcu/rcu.h:13,
                    from kernel/rcu/update.c:49:
   include/trace/events/rcu.h: In function 'perf_trace_rcu_torture_read':
>> include/trace/events/rcu.h:724:17: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
     724 |                 strncpy(__entry->rcutorturename, rcutorturename,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     725 |                         RCUTORTURENAME_LEN);
         |                         ~~~~~~~~~~~~~~~~~~~
   include/trace/perf.h:66:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      66 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS'
      79 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rcu.h:11:25: note: in expansion of macro 'TRACE_EVENT'
      11 | #define TRACE_EVENT_RCU TRACE_EVENT
         |                         ^~~~~~~~~~~
   include/trace/events/rcu.h:723:9: note: in expansion of macro 'TP_fast_assign'
     723 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~
   In file included from include/trace/define_trace.h:102,
                    from include/trace/events/rcu.h:785,
                    from kernel/rcu/rcu.h:13,
                    from kernel/rcu/update.c:49:
   include/trace/events/rcu.h: In function 'trace_event_raw_event_rcu_torture_read':
>> include/trace/events/rcu.h:724:17: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
     724 |                 strncpy(__entry->rcutorturename, rcutorturename,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     725 |                         RCUTORTURENAME_LEN);
         |                         ~~~~~~~~~~~~~~~~~~~
   include/trace/trace_events.h:695:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     695 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS'
      79 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/rcu.h:11:25: note: in expansion of macro 'TRACE_EVENT'
      11 | #define TRACE_EVENT_RCU TRACE_EVENT
         |                         ^~~~~~~~~~~
   include/trace/events/rcu.h:723:9: note: in expansion of macro 'TP_fast_assign'
     723 |         TP_fast_assign(
         |         ^~~~~~~~~~~~~~
--
   In file included from include/trace/define_trace.h:103,
                    from include/trace/events/fscache.h:533,
                    from fs/fscache/internal.h:28,
                    from fs/fscache/main.c:16:
   include/trace/events/fscache.h: In function 'perf_trace_fscache_netfs':
>> include/trace/events/fscache.h:208:21: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
     208 |                     strncpy(__entry->name, netfs->name, 8);
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/perf.h:66:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
      66 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS'
      79 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/fscache.h:196:1: note: in expansion of macro 'TRACE_EVENT'
     196 | TRACE_EVENT(fscache_netfs,
         | ^~~~~~~~~~~
   include/trace/events/fscache.h:206:13: note: in expansion of macro 'TP_fast_assign'
     206 |             TP_fast_assign(
         |             ^~~~~~~~~~~~~~
   In file included from include/trace/define_trace.h:102,
                    from include/trace/events/fscache.h:533,
                    from fs/fscache/internal.h:28,
                    from fs/fscache/main.c:16:
   include/trace/events/fscache.h: In function 'trace_event_raw_event_fscache_netfs':
>> include/trace/events/fscache.h:208:21: warning: 'strncpy' specified bound 8 equals destination size [-Wstringop-truncation]
     208 |                     strncpy(__entry->name, netfs->name, 8);
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/trace/trace_events.h:695:11: note: in definition of macro 'DECLARE_EVENT_CLASS'
     695 |         { assign; }                                                     \
         |           ^~~~~~
   include/trace/trace_events.h:79:30: note: in expansion of macro 'PARAMS'
      79 |                              PARAMS(assign),                   \
         |                              ^~~~~~
   include/trace/events/fscache.h:196:1: note: in expansion of macro 'TRACE_EVENT'
     196 | TRACE_EVENT(fscache_netfs,
         | ^~~~~~~~~~~
   include/trace/events/fscache.h:206:13: note: in expansion of macro 'TP_fast_assign'
     206 |             TP_fast_assign(
         |             ^~~~~~~~~~~~~~


vim +/strncpy +724 include/trace/events/rcu.h

91afaf300269aa9 Paul E. McKenney         2011-10-02  709  
e66c33d579ea566 Steven Rostedt (Red Hat  2013-07-12  710) 	TP_PROTO(const char *rcutorturename, struct rcu_head *rhp,
52494535103986d Paul E. McKenney         2012-11-14  711  		 unsigned long secs, unsigned long c_old, unsigned long c),
91afaf300269aa9 Paul E. McKenney         2011-10-02  712  
52494535103986d Paul E. McKenney         2012-11-14  713  	TP_ARGS(rcutorturename, rhp, secs, c_old, c),
91afaf300269aa9 Paul E. McKenney         2011-10-02  714  
91afaf300269aa9 Paul E. McKenney         2011-10-02  715  	TP_STRUCT__entry(
b3c983142d4584c Paul E. McKenney         2017-06-06  716  		__field(char, rcutorturename[RCUTORTURENAME_LEN])
91afaf300269aa9 Paul E. McKenney         2011-10-02  717  		__field(struct rcu_head *, rhp)
52494535103986d Paul E. McKenney         2012-11-14  718  		__field(unsigned long, secs)
52494535103986d Paul E. McKenney         2012-11-14  719  		__field(unsigned long, c_old)
52494535103986d Paul E. McKenney         2012-11-14  720  		__field(unsigned long, c)
91afaf300269aa9 Paul E. McKenney         2011-10-02  721  	),
91afaf300269aa9 Paul E. McKenney         2011-10-02  722  
91afaf300269aa9 Paul E. McKenney         2011-10-02  723  	TP_fast_assign(
b3c983142d4584c Paul E. McKenney         2017-06-06 @724  		strncpy(__entry->rcutorturename, rcutorturename,
b3c983142d4584c Paul E. McKenney         2017-06-06  725  			RCUTORTURENAME_LEN);
b3c983142d4584c Paul E. McKenney         2017-06-06  726  		__entry->rcutorturename[RCUTORTURENAME_LEN - 1] = 0;
91afaf300269aa9 Paul E. McKenney         2011-10-02  727  		__entry->rhp = rhp;
52494535103986d Paul E. McKenney         2012-11-14  728  		__entry->secs = secs;
52494535103986d Paul E. McKenney         2012-11-14  729  		__entry->c_old = c_old;
52494535103986d Paul E. McKenney         2012-11-14  730  		__entry->c = c;
91afaf300269aa9 Paul E. McKenney         2011-10-02  731  	),
91afaf300269aa9 Paul E. McKenney         2011-10-02  732  
52494535103986d Paul E. McKenney         2012-11-14  733  	TP_printk("%s torture read %p %luus c: %lu %lu",
52494535103986d Paul E. McKenney         2012-11-14  734  		  __entry->rcutorturename, __entry->rhp,
52494535103986d Paul E. McKenney         2012-11-14  735  		  __entry->secs, __entry->c_old, __entry->c)
91afaf300269aa9 Paul E. McKenney         2011-10-02  736  );
91afaf300269aa9 Paul E. McKenney         2011-10-02  737  

:::::: The code at line 724 was first introduced by commit
:::::: b3c983142d4584c9d506b1ed31b65f4292b4aea8 rcutorture: Place event-traced strings into trace buffer

:::::: TO: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ