lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 10 Jul 2022 17:46:54 +0200 From: Hans de Goede <hdegoede@...hat.com> To: Misaka19465 <misaka19465@...doctor.net>, corentin.chary@...il.com, markgross@...nel.org Cc: acpi4asus-user@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: Add key mappings Hi, On 7/10/22 17:34, Hans de Goede wrote: > Hi, > > On 7/10/22 13:37, Misaka19465 wrote: >> On laptops like ASUS TUF Gaming A15, which have hotkeys to start Armoury >> Crate or AURA Sync, these hotkeys are unavailable. This patch add >> mappings for them. >> >> Signed-off-by: Misaka19465 <misaka19465@...doctor.net> > > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Note it will show up in my review-hans branch once I've pushed my > local branch there, which might take a while. > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. I just noticed that this patch submission is not using your real name in "<Firstname> <Lastname>" format as required by the kernel submission guidelines: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Since this is a very trivial patch I'm going to keep it in my tree anyways, but for future kernel submissions please use your real name. Regards, Hans >> --- >> drivers/platform/x86/asus-nb-wmi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c >> index 57a07db65..478dd300b 100644 >> --- a/drivers/platform/x86/asus-nb-wmi.c >> +++ b/drivers/platform/x86/asus-nb-wmi.c >> @@ -522,6 +522,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = { >> { KE_KEY, 0x31, { KEY_VOLUMEDOWN } }, >> { KE_KEY, 0x32, { KEY_MUTE } }, >> { KE_KEY, 0x35, { KEY_SCREENLOCK } }, >> + { KE_KEY, 0x38, { KEY_PROG3 } }, /* Armoury Crate */ >> { KE_KEY, 0x40, { KEY_PREVIOUSSONG } }, >> { KE_KEY, 0x41, { KEY_NEXTSONG } }, >> { KE_KEY, 0x43, { KEY_STOPCD } }, /* Stop/Eject */ >> @@ -574,6 +575,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = { >> { KE_KEY, 0xA5, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV + HDMI */ >> { KE_KEY, 0xA6, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV + HDMI */ >> { KE_KEY, 0xA7, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV + HDMI */ >> + { KE_KEY, 0xB3, { KEY_PROG4 } }, /* AURA */ >> { KE_KEY, 0xB5, { KEY_CALC } }, >> { KE_KEY, 0xC4, { KEY_KBDILLUMUP } }, >> { KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
Powered by blists - more mailing lists