lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <81f7fc52-1adf-a26b-3f43-5fdf975ee57c@opensource.wdc.com>
Date:   Mon, 11 Jul 2022 08:11:59 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     James Bottomley <James.Bottomley@...senPartnership.com>,
        Jilin Yuan <yuanjilin@...rlc.com>, s.shtylyov@....ru
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/ata: fix repeated words in comments

On 7/10/22 23:21, James Bottomley wrote:
> On Sun, 2022-07-10 at 13:22 +0800, Jilin Yuan wrote:
>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>> index 3307ed45fe4d..f2ac8340e769 100644
>> --- a/drivers/ata/libata-eh.c
>> +++ b/drivers/ata/libata-eh.c
>> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list
>> *t)
>>   *
>>   *	Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
>>   *	is non-zero and EH wasn't pending before.  Fast drain ensures
>> - *	that EH kicks in in timely manner.
>> + *	that EH kicks in timely manner.
> 
> The original is correct and the update doesn't make sense.  Of course
> adding an article would make the original read better ...

yep: ...that EH kicks in in a timely manner.

> 
> James
> 
> 


-- 
Damien Le Moal
Western Digital Research

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ