linux-kernel - Re: [PATCH v4] netfs: do not unlock and put the folio twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Jul 2022 12:19:27 +0800
From:   Xiubo Li <xiubli@...hat.com>
To:     Matthew Wilcox <willy@...radead.org>,
        David Howells <dhowells@...hat.com>
Cc:     idryomov@...il.com, jlayton@...nel.org, marc.dionne@...istor.com,
        keescook@...omium.org, kirill.shutemov@...ux.intel.com,
        william.kucharski@...cle.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ceph-devel@...r.kernel.org,
        linux-cachefs@...hat.com, vshankar@...hat.com
Subject: Re: [PATCH v4] netfs: do not unlock and put the folio twice


On 7/7/22 9:26 PM, Matthew Wilcox wrote:
> On Thu, Jul 07, 2022 at 02:21:45PM +0100, David Howells wrote:
>> -					 struct folio *folio, void **_fsdata);
>> +					 struct folio **_folio, void **_fsdata);
> The usual convention is that _foo means "Don't touch".  This should
> probably be named "foliop" (ie pointer to a thing that would normally
> be called folio).
>
This looks good to me.

I will send out the V5 by fixing this and will merge this patch via the 
ceph tree as discussed with David in the IRC and will cc the stable at 
the same time.

Thanks!

-- Xiubo