linux-kernel - Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b694cc9b-7be9-8bba-985f-b4cba69543ca@microchip.com>
Date:   Mon, 11 Jul 2022 10:56:18 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <maz@...nel.org>
CC:     <tglx@...utronix.de>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM

Hi, Marc,

On 11.07.2022 11:49, Marc Zyngier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Claudiu,
> 
> If you send more than a single patch, please add a cover letter.

OK, I'll kept it in mind.

> 
> On Wed, 06 Jul 2022 08:46:29 +0100,
> Claudiu Beznea <claudiu.beznea@...rochip.com> wrote:
>>
>> Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style
>> recommends (at chapter Conditional Compilation) to avoid using
>> preprocessor conditional in .c files.
>> gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is
>> called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM
>> is not defined. With this gc->chip_types->chip.irq_pm_shutdown is
>> populated all the time as it should be as irq_gc_shutdown() is not
>> conditioned by CONFIG_PM.
> 
> By your very own investigations, aic_suspend() and co are utterly
> useless when !PM. And yet you want to *preserve* them, despite being
> dead code? What purpose does it serve (other than some blind
> compliance to a rule)?

Only compliance with the mentioned rule.

Thank you,
Claudiu Beznea

> 
>         M.
> 
> --
> Without deviation from the norm, progress is not possible.