[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YswFG/JdjGC03rHU@linaro.org>
Date: Mon, 11 Jul 2022 14:10:19 +0300
From: Abel Vesa <abel.vesa@...aro.org>
To: "Viorel Suman (OSS)" <viorel.suman@....nxp.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Dong Aisheng <aisheng.dong@....com>,
Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>,
Stefan Agner <stefan@...er.ch>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Linus Walleij <linus.walleij@...aro.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Sascha Hauer <s.hauer@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
Abel Vesa <abelvesa@...nel.org>,
Viorel Suman <viorel.suman@....com>,
Oliver Graute <oliver.graute@...oconnector.com>,
Peng Fan <peng.fan@....com>, Liu Ying <victor.liu@....com>,
Shijie Qin <shijie.qin@....com>, Ming Qian <ming.qian@....com>,
Mirela Rabulea <mirela.rabulea@....com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org, linux-input@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-rtc@...r.kernel.org,
linux-pm@...r.kernel.org, linux-watchdog@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v8 01/15] dt-bindings: clk: imx: Add fsl,scu-clk yaml file
On 22-07-07 15:50:08, Viorel Suman (OSS) wrote:
> From: Abel Vesa <abel.vesa@....com>
>
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'clock' child node of the SCU main node.
>
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> Signed-off-by: Viorel Suman <viorel.suman@....com>
> Acked-by: Stephen Boyd <sboyd@...nel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Shawn, I'm assuming you're going to pick this up through your tree,
right?
> ---
> .../bindings/arm/freescale/fsl,scu.txt | 31 -------------
> .../bindings/clock/fsl,scu-clk.yaml | 43 +++++++++++++++++++
> 2 files changed, 43 insertions(+), 31 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index a87ec15e28d2..ef7f5222ac48 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -79,29 +79,6 @@ Required properties:
> See detailed Resource ID list from:
> include/dt-bindings/firmware/imx/rsrc.h
>
> -Clock bindings based on SCU Message Protocol
> -------------------------------------------------------------
> -
> -This binding uses the common clock binding[1].
> -
> -Required properties:
> -- compatible: Should be one of:
> - "fsl,imx8dxl-clk"
> - "fsl,imx8qm-clk"
> - "fsl,imx8qxp-clk"
> - followed by "fsl,scu-clk"
> -- #clock-cells: Should be 2.
> - Contains the Resource and Clock ID value.
> -- clocks: List of clock specifiers, must contain an entry for
> - each required entry in clock-names
> -- clock-names: Should include entries "xtal_32KHz", "xtal_24MHz"
> -
> -The clock consumer should specify the desired clock by having the clock
> -ID in its "clocks" phandle cell.
> -
> -See the full list of clock IDs from:
> -include/dt-bindings/clock/imx8qxp-clock.h
> -
> Pinctrl bindings based on SCU Message Protocol
> ------------------------------------------------------------
>
> @@ -127,7 +104,6 @@ Required properties for Pinctrl sub nodes:
> Please refer to i.MX8QXP Reference Manual for detailed
> CONFIG settings.
>
> -[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> [2] Documentation/devicetree/bindings/power/power-domain.yaml
> [3] Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt
>
> @@ -208,11 +184,6 @@ firmware {
> &lsio_mu1 1 3
> &lsio_mu1 3 3>;
>
> - clk: clk {
> - compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
> - #clock-cells = <2>;
> - };
> -
> iomuxc {
> compatible = "fsl,imx8qxp-iomuxc";
>
> @@ -265,7 +236,5 @@ serial@...60000 {
> ...
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_lpuart0>;
> - clocks = <&uart0_clk IMX_SC_R_UART_0 IMX_SC_PM_CLK_PER>;
> - clock-names = "ipg";
> power-domains = <&pd IMX_SC_R_UART_0>;
> };
> diff --git a/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
> new file mode 100644
> index 000000000000..f2c48460a399
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,scu-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Clock bindings based on SCU Message Protocol
> +
> +maintainers:
> + - Abel Vesa <abel.vesa@....com>
> +
> +description: i.MX SCU Client Device Node
> + Client nodes are maintained as children of the relevant IMX-SCU device node.
> + This binding uses the common clock binding.
> + (Documentation/devicetree/bindings/clock/clock-bindings.txt)
> + The clock consumer should specify the desired clock by having the clock
> + ID in its "clocks" phandle cell. See the full list of clock IDs from
> + include/dt-bindings/clock/imx8qxp-clock.h
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - fsl,imx8dxl-clk
> + - fsl,imx8qm-clk
> + - fsl,imx8qxp-clk
> + - const: fsl,scu-clk
> +
> + '#clock-cells':
> + const: 2
> +
> +required:
> + - compatible
> + - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + clock-controller {
> + compatible = "fsl,imx8qxp-clk", "fsl,scu-clk";
> + #clock-cells = <2>;
> + };
> --
> 2.25.1
>
Powered by blists - more mailing lists