linux-kernel - Re: [PATCH] ima/evm: Fix potential memory leak in ima_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81ea189fd671947efc61000a745599a4b0573370.camel@linux.ibm.com>
Date:   Mon, 11 Jul 2022 08:04:01 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Jianglei Nie <niejianglei2021@....com>, dmitry.kasatkin@...il.com,
        jmorris@...ei.org, serge@...lyn.com
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto()

On Mon, 2022-07-11 at 15:22 +0800, Jianglei Nie wrote:
> This patch adds the missing kfree() for ima_algo_array allocated by
> kcalloc() to avoid potential memory leak.

Missing is the reason that ima_algo_array is being freed.

Perhaps something like, 
"On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
without freeing the ima_algo_array.   Add the missing kfree() for
ima_algo_array to avoid the potential memory leak."

thanks,

Mimi