linux-kernel - Re: [PATCH -next] certs: Fix Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Jul 2022 17:36:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ren Zhijie <renzhijie2@...wei.com>, dhowells@...hat.com,
        herbert@...dor.apana.org.au, davem@...emloft.net, simo@...hat.com
Cc:     keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] certs: Fix Kconfig dependency



On 7/4/22 04:20, Ren Zhijie wrote:
> If CONFIG_PKCS7_MESSAGE_PARSER=m and CONFIG_FIPS_SIGNATURE_SELFTEST=y,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this:
> 
> crypto/asymmetric_keys/selftest.o: In function `fips_signature_selftest':
> selftest.c:(.init.text+0xc3): undefined reference to `pkcs7_parse_message'
> selftest.c:(.init.text+0x101): undefined reference to `pkcs7_supply_detached_data'
> selftest.c:(.init.text+0x112): undefined reference to `pkcs7_verify'
> selftest.c:(.init.text+0x13f): undefined reference to `pkcs7_validate_trust'
> selftest.c:(.init.text+0x169): undefined reference to `pkcs7_free_message'
> make: *** [vmlinux] Error 1
> 
> To fix this error, add depends on PKCS7_MESSAGE_PARSER=y to FIPS_SIGNATURE_SELFTEST
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>
> ---
>  crypto/asymmetric_keys/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig
> index 3df3fe4ed95f..fe007db96c69 100644
> --- a/crypto/asymmetric_keys/Kconfig
> +++ b/crypto/asymmetric_keys/Kconfig
> @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST
>  	  for FIPS.
>  	depends on KEYS
>  	depends on ASYMMETRIC_KEY_TYPE
> -	depends on PKCS7_MESSAGE_PARSER
> +	depends on PKCS7_MESSAGE_PARSER=y
>  
>  endif # ASYMMETRIC_KEY_TYPE

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
Reported-by: kernel test robot <lkp@...el.com> # 2022-06-30

thanks.

-- 
~Randy