linux-kernel - RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR84MB195309F5BA5B96858024E61FA8879@PH0PR84MB1953.NAMPRD84.PROD.OUTLOOK.COM>
Date:   Mon, 11 Jul 2022 13:10:11 +0000
From:   "Lopez, Jorge A (Security)" <jorge.lopez2@...com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Alex Dewar <alex.dewar@....co.uk>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "tiwai@...e.de" <tiwai@...e.de>,
        "markgross@...nel.org" <markgross@...nel.org>
CC:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: RE: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly
 G2

Hi Alex,

Let me investigate this issue.  The driver maps some keys, so it is possible the list is incomplete.  
It is expected hp_wmi driver to be loaded, Correct?
Can you provide the BIOS version current in your system?


Regards,

Jorge Lopez
Hewlett-Packard 

“Once you stop learning, you start dying”
Albert Einstein

-----Original Message-----
From: Hans de Goede <hdegoede@...hat.com> 
Sent: Monday, July 11, 2022 7:10 AM
To: Alex Dewar <alex.dewar@....co.uk>; dmitry.torokhov@...il.com; tiwai@...e.de; markgross@...nel.org; Lopez, Jorge A (Security) <jorge.lopez2@...com>
Cc: linux-input@...r.kernel.org; linux-kernel@...r.kernel.org; platform-driver-x86@...r.kernel.org
Subject: Re: input/i8042: Malfunctioning brightness keys on HP Elite Dragonfly G2

Hi Alex,

On 7/11/22 09:49, Alex Dewar wrote:
> Hi Hans,
> 
> On Sat, 2022-07-09 at 16:56 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 7/5/22 19:25, Alex Dewar wrote:
>>> Friendly ping? 🙂
>>>
>>> I'm also CC'ing the x86 platform people into this, as I'm not sure 
>>> whether this problem is something more within their remit.
>>
>> Please test the atbkd device with "sudo evemu-record" or "sudo 
>> evtest"
>> and if the brightness keys generate events there, write down the raw 
>> event codes (MSC events).
> 
> I tried this but unfortunately this doesn't seem to be the whole story.
> If I press "decrease brightness" I get:
> Event: time 1657525393.922727, -------------- SYN_REPORT ------------
> Event: time 1657525397.043348, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.043348, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525397.043348, -------------- SYN_REPORT ------------
> Event: time 1657525397.050384, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525397.050384, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> And if I press "increase brightness" I get:
> Event: time 1657525397.050384, -------------- SYN_REPORT ------------
> Event: time 1657525398.607184, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.607184, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 1
> Event: time 1657525398.607184, -------------- SYN_REPORT ------------
> Event: time 1657525398.614190, type 4 (EV_MSC), code 4 (MSC_SCAN), 
> value 81
> Event: time 1657525398.614190, type 1 (EV_KEY), code 190 (KEY_F20), 
> value 0
> 
> There's no difference! And I also get the same thing if I press the
> *actual* mute mic button 😞.
> 
> Any ideas?

From this it looks like we need to use some other interface to get these events (+ ignore the above events).

Do you have a "HP WMI hotkeys" device in your list of input devices?  And are you getting any events on that ?

Likewise do you have a "Video Bus" device and any events on that ?

I've also added Jorge from HP to the Cc. Jorge, can you help with this ?

Regards,

Hans