linux-kernel - Re: [PATCH v7 2/2] iio: light: Add support for ltrf216a sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf=FOt+N6azar5gifvig8FL4sS3LX1kO8CzNCh2yOk-DQ@mail.gmail.com>
Date:   Mon, 11 Jul 2022 15:41:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Shreeya Patel <shreeya.patel@...labora.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>, Zhigang.Shi@...eon.com,
        krisman@...labora.com, linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Collabora Kernel ML <kernel@...labora.com>,
        alvaro.soliverez@...labora.com, dmitry.osipenko@...labora.com
Subject: Re: [PATCH v7 2/2] iio: light: Add support for ltrf216a sensor

On Mon, Jul 11, 2022 at 3:39 PM Shreeya Patel
<shreeya.patel@...labora.com> wrote:
> On 11/07/22 18:36, Andy Shevchenko wrote:
> > On Mon, Jul 11, 2022 at 1:30 PM Shreeya Patel

Please, remove unneeded context when replying!

...

> >> +static const struct regmap_config ltrf216a_regmap_config = {
> >> +       .name = LTRF216A_DRV_NAME,
> >> +       .reg_bits = 8,
> >> +       .val_bits = 8,
> >> +       .max_register = LTRF216A_MAX_REG,
> > Why do you use regmap locking? What for?
>
> Why do we want to skip the internal locking if it doesn't bring any
> benefits?

Can you elaborate on the "no benefits" part, please?

-- 
With Best Regards,
Andy Shevchenko