linux-kernel - Re: [PATCH v1 2/2] iio: adc: npcm: Add NPCM8XX support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jul 2022 16:14:57 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     Avi Fishman <avifishman70@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Joel Stanley <joel@....id.au>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        zhengbin13@...wei.com, OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v1 2/2] iio: adc: npcm: Add NPCM8XX support

On Mon, Jul 11, 2022 at 3:59 PM Tomer Maimon <tmaimon77@...il.com> wrote:
>
> Adding ADC NPCM8XX support to NPCM ADC driver.
> ADC NPCM8XX uses a different resolution and voltage reference.
>
> As part of adding NPCM8XX support:
> - Add NPCM8XX specific compatible string.
> - Add data to handle architecture-specific ADC parameters.

Good patch, but one change can make it even better!

...

>         struct device *dev = &pdev->dev;
> +       const struct of_device_id *match;
>
>         indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*info));
>         if (!indio_dev)
>                 return -ENOMEM;
>         info = iio_priv(indio_dev);
>
> -       mutex_init(&info->lock);
> +       match = of_match_node(npcm_adc_match, pdev->dev.of_node);
> +       if (!match || !match->data) {
> +               dev_err(dev, "Failed getting npcm_adc_data\n");
> +               return -ENODEV;
> +       }
>
> +       info->data = (struct npcm_adc_info *)match->data;

Instead of above

  info->data = device_get_match_data(dev);
  if (!info->data)
    return -ENODEV;

-- 
With Best Regards,
Andy Shevchenko