linux-kernel - Re: [PATCH] tty: 8250: Add support for Brainboxes PX cards.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ysw0r9xSrbx188xe@kroah.com>
Date:   Mon, 11 Jul 2022 16:33:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Cameron Williams <cang1@...e.co.uk>
Cc:     jirislaby@...nel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: 8250: Add support for Brainboxes PX cards.

On Mon, Jul 11, 2022 at 02:50:35PM +0100, Cameron Williams wrote:
> Add support for some of the Brainboxes PCIe (PX) range of
> serial cards, including the PX-101, PX-235/PX-246,
> PX-203/PX-257, PX-260/PX-701, PX-310, PX-313,
> PX-320/PX-324/PX-376/PX-387, PX-335/PX-346, PX-368, PX-420,
> PX-803 and PX-846.
> 
> Signed-off-by: Cameron Williams <cang1@...e.co.uk>
> ---
>  drivers/tty/serial/8250/8250_pci.c | 116 ++++++++++++++++++++++++++++-
>  1 file changed, 113 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index a17619db7939..4a0ea79ca9d6 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -4973,7 +4973,7 @@ static const struct pci_device_id serial_pci_tbl[] = {
>  	/*
>  	* Brainboxes UC-101
>  	*/
> -	{       PCI_VENDOR_ID_INTASHIELD, 0x0BA1,
> +	{	PCI_VENDOR_ID_INTASHIELD, 0x0BA1,

You seem to have included a bunch of no-needed whitespace changes.  Can
you redo this to only make the additional device id support instead?

thanks,

greg k-h