linux-kernel - Re: [PATCH v2] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YsxIZfhgdQnh2QsJ@bombadil.infradead.org>
Date:   Mon, 11 Jul 2022 08:57:25 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Aaron Tomlin <atomlin@...mlin.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Cc:     Aaron Tomlin <atomlin@...hat.com>, rostedt@...dmis.org,
        cl@...ux.com, pmladek@...e.com, mbenes@...e.cz,
        christophe.leroy@...roup.eu, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
        ghalat@...hat.com, oleksandr@...alenko.name, neelx@...hat.com,
        daniel.thompson@...aro.org, hch@...radead.org, tglx@...utronix.de,
        linux-rt-users@...r.kernel.org
Subject: Re: [PATCH v2] module: kallsyms: Ensure preemption in add_kallsyms()
 with PREEMPT_RT

On Thu, Jul 07, 2022 at 07:56:19PM +0100, Aaron Tomlin wrote:
> On Thu 2022-07-07 10:20 -0700, Luis Chamberlain wrote:
> > This is incredibly important information which should be added to the
> > commit log, specialy as PREEMPT_RT=y becomes a first class citizen.
> 
> Understood.
> 
> > 
> > > So, I would say this was a regression since earlier preemption was
> > > not disabled and we would dereference RCU-protected pointers explicitly
> > > i.e. without using the more appropriate rcu_dereference() family
> > > of primitives. That being said, these pointers cannot change in this
> > > context as explained previously.
> > > 
> > > Would the above be suitable - just to confirm before I send another
> > > iteration?
> > 
> > Yes, I would send this to Linus for the rc series. Please adjust the
> > commit log with all this information.
> 
> Will do.
> 
> > BTW I think there is just one more fix pending from you right?
> 
> Yes - I will send/or prepare it as a partial revert:
> 's/strscpy/strlcpy/' with a brief explanation.

If that is just the kallsyms fix Adrian Hunter already sent a fix:

https://lkml.kernel.org/r/20220701094403.3044-1-adrian.hunter@intel.com         

  Luis