linux-kernel - Re: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220711123728.79bc0f93@gandalf.local.home>
Date:   Mon, 11 Jul 2022 12:37:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     Schspa Shi <schspa@...il.com>, pmladek@...e.com,
        sergey.senozhatsky@...il.com, linux-rt-users@...r.kernel.org,
        linux-kernel@...r.kernel.org, bigeasy@...utronix.de,
        tglx@...utronix.de,
        "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>
Subject: Re: [PATCH 5.10-rt] printk: fix suppressed message print when
 reboot/panic


I guess the lclaudio@...g.org is no longer valid. I need to update my
address book :-/

On Mon, 11 Jul 2022 12:31:28 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> Luis,
> 
> Care to add this patch into the 5.10-rt stable?
> 
> Thanks,
> 
> -- Steve
> 
> On Mon, 21 Mar 2022 10:36:55 +0106
> John Ogness <john.ogness@...utronix.de> wrote:
> 
> > On 2022-03-21, Schspa Shi <schspa@...il.com> wrote:  
> > > Update printk_seq for suppressed message.
> > >
> > > Affects 5.9-rt and 5.10-rt
> > >
> > > When message is suppressed, printk_seq should be updated, otherwise
> > > this message will be printed when reboot. This problem was introduced
> > > in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer").
> > >
> > > Signed-off-by: Schspa Shi <schspa@...il.com>    
> > 
> > Reviewed-by: John Ogness <john.ogness@...utronix.de>
> > 
> > Nice catch. Thanks.
> > 
> > 5.15-rt also has this issue, although the fix is slightly different. For
> > 5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires
> > the console locked. Would you like to post a patch for 5.15-rt as well,
> > or would you like me to do it?
> > 
> > 5.16 and beyond does not have this issue.
> > 
> > John Ogness  
>