linux-kernel - Re: [PATCH] PCI: hv: Take a const cpumask in hv_compose_msi_req_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220711185831.rjjy3h7qbqa72g5c@liuwe-devbox-debian-v2>
Date:   Mon, 11 Jul 2022 18:58:31 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc:     Samuel Holland <samuel@...lland.org>,
        Marc Zyngier <maz@...nel.org>,
        kernel test robot <lkp@...el.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Dexuan Cui <decui@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] PCI: hv: Take a const cpumask in
 hv_compose_msi_req_get_cpu()

On Fri, Jul 08, 2022 at 04:27:00AM +0000, Michael Kelley (LINUX) wrote:
> From: Samuel Holland <samuel@...lland.org> Sent: Thursday, July 7, 2022 5:50 PM
> > 
> > The cpumask that is passed to this function ultimately comes from
> > irq_data_get_effective_affinity_mask(), which was recently changed to
> > return a const cpumask pointer. The first level of functions handling
> > the affinity mask were updated, but not this helper function.
> > 
> > Fixes: 4d0b8298818b ("genirq: Return a const cpumask from irq_data_get_affinity_mask")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Samuel Holland <samuel@...lland.org>
> > ---
> > 
> >  drivers/pci/controller/pci-hyperv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index aebada45569b..e7c6f6629e7c 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -1635,7 +1635,7 @@ static u32 hv_compose_msi_req_v1(
> >   * Create MSI w/ dummy vCPU set targeting just one vCPU, overwritten
> >   * by subsequent retarget in hv_irq_unmask().
> >   */
> > -static int hv_compose_msi_req_get_cpu(struct cpumask *affinity)
> > +static int hv_compose_msi_req_get_cpu(const struct cpumask *affinity)
> >  {
> >  	return cpumask_first_and(affinity, cpu_online_mask);
> >  }
> > --
> > 2.35.1
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Applied to hyperv-next. Thanks.