linux-kernel - Re: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4df9485a-4947-6f2c-e3f3-89ff44e12113@amd.com>
Date:   Mon, 11 Jul 2022 14:29:42 -0500
From:   Nathan Fontenot <nafonten@....com>
To:     Perry Yuan <Perry.Yuan@....com>, rafael.j.wysocki@...el.com,
        viresh.kumar@...aro.org, Ray.Huang@....com
Cc:     Deepak.Sharma@....com, Mario.Limonciello@....com,
        Nathan.Fontenot@....com, Alexander.Deucher@....com,
        Jinzhou.Su@....com, Xinmei.Huang@....com, Xiaojian.Du@....com,
        Li.Meng@....com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check

On 7/9/22 09:20, Perry Yuan wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@....com>
> ---
>  drivers/cpufreq/cppc_cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 24eaf0ec344d..9adb7612993e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
>  {
>  	int ret;
>  
> -	if ((acpi_disabled) || !acpi_cpc_valid())
> +	if (!acpi_cpc_valid())

Same comment here as for patch 13/14, this change should be part of patch 11/14.

-Nathan

>  		return -ENODEV;
>  
>  	cppc_check_hisi_workaround();