linux-kernel - Re: [PATCH] trace: atomic64_read(&ioc->vtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jul 2022 16:55:32 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Li kunyu <kunyu@...china.com>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an
 extra semicolon

Jens,

Want to take this one? Or I can if you don't.

-- Steve


On Wed, 29 Jun 2022 11:00:13 +0800
Li kunyu <kunyu@...china.com> wrote:

> I think this semicolon could be deleted.
> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> ---
>  include/trace/events/iocost.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index e282ce02fa2d..6d1626e7a4ce 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
>  
>  	TP_fast_assign(
>  		__assign_str(devname, ioc_name(ioc));
> -		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> +		__entry->old_vrate = atomic64_read(&ioc->vtime_rate);
>  		__entry->new_vrate = new_vrate;
>  		__entry->busy_level = ioc->busy_level;
>  		__entry->read_missed_ppm = missed_ppm[READ];