linux-kernel - Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220711211047.952F4C34115@smtp.kernel.org>
Date:   Mon, 11 Jul 2022 14:10:45 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Robert Marko <robimarko@...il.com>, absahu@...eaurora.org,
        agross@...nel.org, bjorn.andersson@...aro.org,
        devicetree@...r.kernel.org, dmitry.baryshkov@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        mturquette@...libre.com, robh+dt@...nel.org, tdas@...eaurora.org
Cc:     Robert Marko <robimarko@...il.com>
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src

Quoting Robert Marko (2022-05-15 14:00:47)
> diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> index 3204d550ff76..42d185fe19c8 100644
> --- a/drivers/clk/qcom/gcc-ipq8074.c
> +++ b/drivers/clk/qcom/gcc-ipq8074.c
> @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src = {
>                         },
>                         .num_parents = 1,
>                         .ops = &clk_branch2_ops,
> +                       .flags = CLK_IS_CRITICAL,
>                 },

Why not just remove the clk from the driver? Is anything using it?