linux-kernel - Re: [PATCH] PCI/doc: Convert examples to generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220711231918.GA707416@bhelgaas>
Date:   Mon, 11 Jul 2022 18:19:18 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     linux-pci@...r.kernel.org
Cc:     Vaibhav Gupta <vaibhavgupta40@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/doc: Convert examples to generic power management

[+cc Jonathan, linux-doc, linux-kernel; sorry I missed you earlier]

On Tue, Jun 07, 2022 at 06:29:46PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
> deprecated.  Convert sample code to the generic power management framework.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

I applied this to pci/pm for v5.20.  Let me know if you object!

> ---
>  Documentation/PCI/pci-iov-howto.rst | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/PCI/pci-iov-howto.rst b/Documentation/PCI/pci-iov-howto.rst
> index b9fd003206f1..27d35933cea2 100644
> --- a/Documentation/PCI/pci-iov-howto.rst
> +++ b/Documentation/PCI/pci-iov-howto.rst
> @@ -125,14 +125,14 @@ Following piece of code illustrates the usage of the SR-IOV API.
>  		...
>  	}
>  
> -	static int dev_suspend(struct pci_dev *dev, pm_message_t state)
> +	static int dev_suspend(struct device *dev)
>  	{
>  		...
>  
>  		return 0;
>  	}
>  
> -	static int dev_resume(struct pci_dev *dev)
> +	static int dev_resume(struct device *dev)
>  	{
>  		...
>  
> @@ -165,8 +165,7 @@ Following piece of code illustrates the usage of the SR-IOV API.
>  		.id_table =	dev_id_table,
>  		.probe =	dev_probe,
>  		.remove =	dev_remove,
> -		.suspend =	dev_suspend,
> -		.resume =	dev_resume,
> +		.driver.pm =	&dev_pm_ops,
>  		.shutdown =	dev_shutdown,
>  		.sriov_configure = dev_sriov_configure,
>  	};
> -- 
> 2.25.1
>