linux-kernel - Re: [PATCH -next] tpm: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ystog1WaJZ5XgJAP@kernel.org>
Date:   Mon, 11 Jul 2022 03:02:11 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     peterhuewe@....de, jgg@...pe.ca, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] tpm: fix platform_no_drv_owner.cocci warning

On Fri, Jul 01, 2022 at 05:13:22PM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/char/tpm/tpm_tis_i2c.c:379:3-8: No need to set .owner here.  The core will do it.
> 
> Remove .owner field if calls are used which set it automatically
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/char/tpm/tpm_tis_i2c.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index 8e0686fe4eb1..ba0911b1d1ff 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -376,7 +376,6 @@ MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
>  
>  static struct i2c_driver tpm_tis_i2c_driver = {
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "tpm_tis_i2c",
>  		.pm = &tpm_tis_pm,
>  		.of_match_table = of_match_ptr(of_tis_i2c_match),
> -- 
> 2.20.1.7.g153144c
> 


Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko