linux-kernel - Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <798B000F-043A-4C5A-82C0-D7CF1BCDEDE1@gmail.com>
Date:   Mon, 11 Jul 2022 16:42:14 -0700
From:   Nadav Amit <nadav.amit@...il.com>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        X86 ML <x86@...nel.org>, Linux MM <linux-mm@...ck.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done

On Jul 11, 2022, at 3:50 PM, Andy Lutomirski <luto@...nel.org> wrote:

> On 7/10/22 16:33, Nadav Amit wrote:
>> From: Nadav Amit <namit@...are.com>
>> Currently, if flush_tlb_func() does not flush for some reason, the
>> tracing of the flush will be done only in certain cases, depending on
>> the reason of the flush. Be consistent and just do not trace in all
>> cases when the flush was eventually not done.
>> Suggested-by: Dave Hansen <dave.hansen@...ux.intel.com>
>> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
>> Cc: Andy Lutomirski <luto@...nel.org>
>> Signed-off-by: Nadav Amit <namit@...are.com>
> 
> 
> Can you remove this comment, too?
> 
>>  	/* Tracing is done in a unified manner to reduce the code size */

Yes. I will send v2.

… And if you have time, can you please review the other TLB patch that I
sent? It is a really urgent one.

Thanks,
Nadav