linux-kernel - Re: [PATCH] sched/schedutil: Fix deadlock between cpuset and cpu hotplug when using schedutil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jul 2022 08:50:37 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Xuewen Yan <xuewen.yan94@...il.com>
Cc:     Xuewen Yan <xuewen.yan@...soc.com>, rafael@...nel.org,
        viresh.kumar@...aro.org, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, linux-kernel@...r.kernel.org,
        ke.wang@...soc.com, xuewyan@...mail.com, linux-pm@...r.kernel.org
Subject: Re: [PATCH] sched/schedutil: Fix deadlock between cpuset and cpu
 hotplug when using schedutil



On 7/11/22 08:43, Xuewen Yan wrote:
> On Mon, Jul 11, 2022 at 3:32 PM Lukasz Luba <lukasz.luba@....com> wrote:
>>
>> Hi Xuewen,
>>
>> On 7/11/22 08:21, Xuewen Yan wrote:
>>> Hi all
>>>
>>> This deadlock is inevitable, any comment?
>>
>> Could you tell me how to reproduce this?
>> Is there a need of special cgroup setup?
> 
> This deadlock occurs when we run the monkey test on an Android phone,
> at the same time, randomly put online or offline a cpu core.
> Indeed the thread-A which get the cgroup_threadgroup_rwsem and waiting
> for the cpu_hotplug_lock is the thread whose name is "OomAdjuster" in
> android.

Thanks, let me have a look. We have some hotplug stress tests in our
EAS mainline integration tests, which haven't triggered this issue.
I'll try to trigger this on mainline kernel.

> 
> And I see the cpu_hotplug_lock is added by the patch:
> https://lore.kernel.org/all/20220121101210.84926-1-zhangqiao22@huawei.com/

Thanks for the pointer.