linux-kernel - [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220711024718.1700067-1-PaddyKP_Yao@asus.com>
Date:   Mon, 11 Jul 2022 10:47:18 +0800
From:   <PaddyKP_Yao@...s.com>
To:     <andy.shevchenko@...il.com>, <hdegoede@...hat.com>
CC:     <paddykp_yao@...s.com>, <acpi4asus-user@...ts.sourceforge.net>,
        <corentin.chary@...il.com>, <ispaddy@...il.com>,
        <linux-kernel@...r.kernel.org>, <luke@...nes.dev>,
        <mgross@...ux.intel.com>, <platform-driver-x86@...r.kernel.org>,
        PaddyKP_Yao <PaddyKP_Yao@...s.com>
Subject: [PATCH v2 1/1] platform/x86: asus-wmi: Add mic-mute LED classdev support

From: PaddyKP_Yao <PaddyKP_Yao@...s.com>

In some new ASUS devices, hotkey Fn+F13 is used for mic mute. If mic-mute
LED is present by checking WMI ASUS_WMI_DEVID_MICMUTE_LED, we will add a
mic-mute LED classdev, asus::micmute, in the asus-wmi driver to control
it. The binding of mic-mute LED controls will be swithched with LED
trigger.

Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@...s.com>
---
V1 -> V2: fix typo for 'present' and remove unnecessary pr_info() log

 drivers/platform/x86/Kconfig               |  2 ++
 drivers/platform/x86/asus-wmi.c            | 25 ++++++++++++++++++++++
 include/linux/platform_data/x86/asus-wmi.h |  1 +
 3 files changed, 28 insertions(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index f915cf67aa26..74769050b770 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -274,6 +274,8 @@ config ASUS_WMI
        select INPUT_SPARSEKMAP
        select LEDS_CLASS
        select NEW_LEDS
+       select LEDS_TRIGGERS
+       select LEDS_TRIGGER_AUDIO
        select ACPI_PLATFORM_PROFILE
        help
          Say Y here if you have a WMI aware Asus laptop (like Eee PCs or new
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index e14fb5fa7324..40c0e00a4b71 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -191,6 +191,7 @@ struct asus_wmi {
        int kbd_led_wk;
        struct led_classdev lightbar_led;
        int lightbar_led_wk;
+       struct led_classdev micmute_led;
        struct workqueue_struct *led_workqueue;
        struct work_struct tpd_led_work;
        struct work_struct wlan_led_work;
@@ -906,12 +907,23 @@ static enum led_brightness lightbar_led_get(struct led_classdev *led_cdev)
        return result & ASUS_WMI_DSTS_LIGHTBAR_MASK;
 }

+static int micmute_led_set(struct led_classdev *led_cdev,
+                          enum led_brightness brightness)
+{
+       int state = brightness != LED_OFF;
+       int err;
+
+       err = asus_wmi_set_devstate(ASUS_WMI_DEVID_MICMUTE_LED, state, NULL);
+       return err < 0 ? err : 0;
+}
+
 static void asus_wmi_led_exit(struct asus_wmi *asus)
 {
        led_classdev_unregister(&asus->kbd_led);
        led_classdev_unregister(&asus->tpd_led);
        led_classdev_unregister(&asus->wlan_led);
        led_classdev_unregister(&asus->lightbar_led);
+       led_classdev_unregister(&asus->micmute_led);

        if (asus->led_workqueue)
                destroy_workqueue(asus->led_workqueue);
@@ -983,6 +995,19 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
                                           &asus->lightbar_led);
        }

+       if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
+               asus->micmute_led.name = "asus::micmute";
+               asus->micmute_led.max_brightness = 1;
+               asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
+               asus->micmute_led.brightness_set_blocking = micmute_led_set;
+               asus->micmute_led.default_trigger = "audio-micmute";
+
+               rv = led_classdev_register(&asus->platform_device->dev,
+                                               &asus->micmute_led);
+               if (rv)
+                       goto error;
+       }
+
 error:
        if (rv)
                asus_wmi_led_exit(asus);
diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h
index 17dc5cb6f3f2..38ee75874d11 100644
--- a/include/linux/platform_data/x86/asus-wmi.h
+++ b/include/linux/platform_data/x86/asus-wmi.h
@@ -49,6 +49,7 @@
 #define ASUS_WMI_DEVID_LED4            0x00020014
 #define ASUS_WMI_DEVID_LED5            0x00020015
 #define ASUS_WMI_DEVID_LED6            0x00020016
+#define ASUS_WMI_DEVID_MICMUTE_LED             0x00040017

 /* Backlight and Brightness */
 #define ASUS_WMI_DEVID_ALS_ENABLE      0x00050001 /* Ambient Light Sensor */
--
2.34.1

===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed.If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. If any, please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Furthermore, any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK. Thank you for your cooperation.
===================================================================================================================================